doc: change color of doctag on night mode - #38652
Conversation
Sorry, something went wrong.
DerekNonGeneric
left a comment
There was a problem hiding this comment.
Sweet!
Thanks, you can do .hljs-type if you want to too, but that would also need the light-mode styles too, so probably not in this PR.
/cc @nodejs/documentation as an FYI
Sorry, something went wrong.
|
I think it is a great idea. I will open other PR to adjust .hljs-type. |
Sorry, something went wrong.
|
@Ayase-252, that sounds like a good idea! Pick a nice color for .hljs-type please. It should be distinguishable from the JSDoc tag (not the same color). Thanks in advance. :) |
Sorry, something went wrong.
|
/to @Ayase-252 check out what GitHub has done here. They are like whitish or something in the dark mode, so you may not want to diverge too far from that.
That is a gist in darkmode, so check it for yourself. |
Sorry, something went wrong.
|
OK, will check. Looks like Github uses same color of variable to .hljs-type. Let's do the same to see how it looks in Node.js doc. |
Sorry, something went wrong.
|
@Ayase-252, they use a different syntax highlighter (and it is broken as you can see). It is probably best to hold off on making the PR if this is challenging, but I will keep you posted if I make any progress. |
Sorry, something went wrong.
|
@DerekNonGeneric
FYI, vscode seems do the job right.
I think this PR is free from the minor issue. |
Sorry, something went wrong.
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: #38641 PR-URL: #38652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Demo:
Fixes: #38641