test: stream.finished detects a destroyed IncomingMessage - #38661
Closed
Linkgoron wants to merge 2 commits into
Closed
test: stream.finished detects a destroyed IncomingMessage#38661Linkgoron wants to merge 2 commits into
Linkgoron wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Add a test to verify that stream.finished works correctly on IncomingMessage refs: nodejs#38657
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
addaleax
approved these changes
May 13, 2021
Comment thread
test/parallel/test-stream-finished.js
Outdated
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 14, 2021
juanarbol
approved these changes
May 14, 2021
lpinca
approved these changes
May 16, 2021
jasnell
pushed a commit
that referenced
this pull request
May 17, 2021
Add a test to verify that stream.finished works correctly on IncomingMessage refs: #38657 PR-URL: #38661 Refs: #38657 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 18, 2021
Add a test to verify that stream.finished works correctly on IncomingMessage refs: #38657 PR-URL: #38661 Refs: #38657 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test to verify that stream.finished works correctly on IncomingMessage, as it looks like it didn't work on Node 15, but now works on Node 16.
The test that I added does not pass on Node 15, but passes on Node 16.
refs: #38657