bootstrap: include vm and contextify binding into the snapshot - #38677
Closed
joyeecheung wants to merge 2 commits into
Closed
bootstrap: include vm and contextify binding into the snapshot#38677joyeecheung wants to merge 2 commits into
joyeecheung wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
In addition, defer the patching of the vm module based on the value of --experimental-vm-modules to runtime.
devsnek
approved these changes
May 13, 2021
Comment thread
lib/vm.js
addaleax
approved these changes
May 13, 2021
cjihrig
approved these changes
May 14, 2021
jasnell
approved these changes
May 14, 2021
This comment has been minimized.
Trott
approved these changes
May 15, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It keeps flaking on #38226 To be safe, I checked that test and the hash seed test again and it seems alright, so I am going to land it. |
Sorry, something went wrong.
legendecas
approved these changes
May 19, 2021
joyeecheung
added a commit
that referenced
this pull request
May 19, 2021
In addition, defer the patching of the vm module based on the value of --experimental-vm-modules to runtime. PR-URL: #38677 Refs: #35711 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
In addition, defer the patching of the vm module based on the value of --experimental-vm-modules to runtime. PR-URL: #38677 Refs: #35711 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
Doesn't land cleanly on v14.x-staging. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition, defer the patching of the vm module based on the
value of --experimental-vm-modules to runtime.
Refs: #35711