FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor `test-readline-interface` to be shorter by juanarbol · Pull Request #38691 · nodejs/node · GitHub

/ node Public

test: refactor test-readline-interface to be shorter - #38691

Closed
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juan/test-shorter
Closed

test: refactor test-readline-interface to be shorter#38691
juanarbol wants to merge 1 commit into
nodejs:masterfrom
juanarbol:juan/test-shorter

Conversation

Copy link
Copy Markdown
Member

No description provided.

github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 14, 2021
juanarbol force-pushed the juan/test-shorter branch 2 times, most recently from d741b5b to 051067f Compare May 14, 2021 23:49
juanarbol force-pushed the juan/test-shorter branch from 051067f to 65ae445 Compare May 15, 2021 00:29

This comment has been minimized.

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 15, 2021

This comment has been minimized.

nodejs-github-bot commented May 16, 2021
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

jasnell commented May 17, 2021

Copy link
Copy Markdown
Member

Landed in 354b0be

jasnell closed this May 17, 2021
jasnell pushed a commit that referenced this pull request May 17, 2021
PR-URL: #38691
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 18, 2021
PR-URL: #38691
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol deleted the juan/test-shorter branch August 26, 2021 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL