lib: refactor to use optional chaining - #38697
Conversation
Sorry, something went wrong.
This PR migrates expressions such as `a ? a.b : c` to `a?.b ?? c` Codemod script: https://github.com/pd4d10/nodejs-codemod/blob/main/src/optional-chaining.ts
|
I'm not sure we want to do that after #38245... |
Sorry, something went wrong.
|
|
||
| get fd() { | ||
| return this.#channel ? this.#channel.fd : undefined; | ||
| return this.#channel?.fd ?? undefined; |
There was a problem hiding this comment.
| return this.#channel?.fd ?? undefined; | |
| return this.#channel?.fd; |
Sorry, something went wrong.
| return false; | ||
| const request = stream[kRequest]; | ||
| return request ? request.readable : stream.readable; | ||
| return request?.readable ?? stream.readable; |
There was a problem hiding this comment.
| return request?.readable ?? stream.readable; | |
| return stream[kRequest]?.readable ?? stream.readable; |
Sorry, something went wrong.
| function debugStreamObj(stream, message, ...args) { | ||
| const session = stream[kSession]; | ||
| const type = session ? session[kType] : undefined; | ||
| const type = session?.kType ?? undefined; |
There was a problem hiding this comment.
| const type = session?.kType ?? undefined; | |
| const type = stream[kSession]?.[kType]; |
Sorry, something went wrong.
|
|
||
| function onError(msg, err, callback) { | ||
| const triggerAsyncId = msg.socket ? msg.socket[async_id_symbol] : undefined; | ||
| const triggerAsyncId = msg.socket?.[async_id_symbol] ?? undefined; |
There was a problem hiding this comment.
| const triggerAsyncId = msg.socket?.[async_id_symbol] ?? undefined; | |
| const triggerAsyncId = msg.socket?.[async_id_symbol]; |
Sorry, something went wrong.
OK. Given this information, I guess we should hold it until the performance issues solved. |
Sorry, something went wrong.
Mifrill
left a comment
There was a problem hiding this comment.
Those changes look great, and I see the potential performance issue was also taken into consideration, that's awesome, however would like to raise a hand and ask if the chaining is slower than the ternary operator.
📝 CC @ronag #50337 (comment)
Sorry, something went wrong.
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Sorry, something went wrong.
|
Closing this because it has stalled. Feel free to reopen if this issue/PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Sorry, something went wrong.
This PR migrates expressions such as a ? a.b : c to a?.b ?? c
Codemod script:
https://github.com/pd4d10/nodejs-codemod/blob/main/src/optional-chaining.ts
Also see:
#38609