FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use HandleScope in StreamReq::Done() by RaisinTen · Pull Request #38720 · nodejs/node · GitHub

/ node Public

src: use HandleScope in StreamReq::Done() - #38720

Closed
RaisinTen wants to merge 2 commits into
nodejs:masterfrom
RaisinTen:src/use-HandleScope-in-StreamReq.Done
ConversationCommits (2)ChecksFiles changed
Closed

src: use HandleScope in StreamReq::Done()#38720
RaisinTen wants to merge 2 commits into
nodejs:masterfrom
RaisinTen:src/use-HandleScope-in-StreamReq.Done

Conversation

RaisinTen commented May 18, 2021

Copy link
Copy Markdown
Member

Fixes: #38707

This comment has been minimized.

Sign in to view
Ayase-252 reviewed May 18, 2021
View reviewed changes
Comment thread test/parallel/test-https-agent-unref-socket.js Outdated
Apply suggestions from code review
d89dbd1 
Co-authored-by: Qingyu Deng <i@ayase-lab.com>

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view
RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 19, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented May 21, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38254/ 💚

jasnell commented May 21, 2021

Copy link
Copy Markdown
Member

Landed in fcdb1db

jasnell closed this May 21, 2021
jasnell pushed a commit that referenced this pull request May 21, 2021
src: use HandleScope in StreamReq::Done()
fcdb1db 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen deleted the src/use-HandleScope-in-StreamReq.Done branch May 22, 2021 14:35
danielleadams pushed a commit that referenced this pull request May 31, 2021
src: use HandleScope in StreamReq::Done()
4e33532 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams mentioned this pull request May 31, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 16, 2021
src: use HandleScope in StreamReq::Done()
c254186 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
src: use HandleScope in StreamReq::Done()
ee66cfc 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
src: use HandleScope in StreamReq::Done()
2d32031 
Fixes: #38707

PR-URL: #38720
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau mentioned this pull request Jul 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Ayase-252 Ayase-252 left review comments
jasnell jasnell approved these changes
addaleax addaleax approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unref a socket raise v8 error

5 participants

Back | FazBrowse Home | New Git URL