lib: support fs_event_wrap in the snapshot and load more modules eagerly - #38737
Closed
joyeecheung wants to merge 3 commits into
Closed
lib: support fs_event_wrap in the snapshot and load more modules eagerly#38737joyeecheung wants to merge 3 commits into
joyeecheung wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
So that they are included in the builtin snapshot
Now that more modules are included in the snapshot, it's not necessary to lazy load them anymore
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
VoltrexKeyva
approved these changes
May 19, 2021
addaleax
approved these changes
May 19, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we support more modules in the snapshot, it's no longer necessary to lazy load them for speeding up startup.
Refs: #35711