FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: update ESLint to 7.27.0 by lpinca · Pull Request #38764 · nodejs/node · GitHub

/ node Public

tools: update ESLint to 7.27.0 - #38764

Closed
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:update/eslint
Closed

tools: update ESLint to 7.27.0#38764
lpinca wants to merge 1 commit into
nodejs:masterfrom
lpinca:update/eslint

Conversation

lpinca commented May 22, 2021

Copy link
Copy Markdown
Member

Update ESLint to 7.27.0

github-actions Bot added the tools Issues and PRs related to the tools directory. label May 22, 2021

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM assuming this was generated with the usual tools/updat-eslint.shscript. I certainly like the 44K lines removed.

bl-ue commented May 25, 2021
edited
Loading

Copy link
Copy Markdown
Contributor

Yeah, tasty crunch. 😋 Looks like they removed their lodash dependencies, that's why 🤔

eslint/eslint#14098 & eslint/eslint#14287 are the causes of this.

Copy link
Copy Markdown
Contributor

woot, lodash is a scourge that should be wiped from the planet.

lpinca added a commit that referenced this pull request May 26, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

lpinca commented May 26, 2021

Copy link
Copy Markdown
Member Author

Landed in b6471c9.

lpinca closed this May 26, 2021
lpinca deleted the update/eslint branch May 26, 2021 16:22
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request May 31, 2021
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL