tools: update setup-node@v1 to setup-node@v2 - #38825
Closed
JayFate wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gengjiawen
approved these changes
May 27, 2021
targos
approved these changes
May 27, 2021
richardlau
reviewed
May 27, 2021
Comment thread
tools/gyp/.github/workflows/node-gyp.yml
Outdated
lpinca
approved these changes
May 27, 2021
lpinca
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with @richardlau's comment addressed.
Sorry, something went wrong.
Signed-off-by: pengjie <37610029@qq.com>
richardlau
approved these changes
May 28, 2021
gengjiawen
pushed a commit
that referenced
this pull request
May 29, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Copy link
Copy Markdown
Member
|
Landed in 4c508f5. Thanks for the contribution :) |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Signed-off-by: pengjie <37610029@qq.com> PR-URL: #38825 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update setup-node@v1 to setup-node@v2.
Signed-off-by: pengjie 37610029@qq.com