FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: upgrade npm to 7.15.0 by npm-robot · Pull Request #38831 · nodejs/node · GitHub

/ node Public

deps: upgrade npm to 7.15.0 - #38831

Closed
npm-robot wants to merge 1 commit into
nodejs:masterfrom
npm:npm-7.15.0
ConversationCommits (1)ChecksFiles changed
Closed

deps: upgrade npm to 7.15.0#38831
npm-robot wants to merge 1 commit into
nodejs:masterfrom
npm:npm-7.15.0

Conversation

npm-robot commented May 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

v7.15.0 (2021-05-27)

FEATURES

BUG FIXES

DOCUMENTATION

DEPENDENCIES

  • 7b56bfdf3 cacache@15.2.0:
    • feat: allow fully deleting indices
    • feat: add a validateEntry option to compact
    • chore: lint
    • chore: use standard npm style release scripts
  • dbbc151a3 npm-audit-report@2.1.5:
  • 5b2604507 chore(package-lock): update devDependencies (@Gar)

AUTOMATION

github-actions Bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels May 28, 2021

VoltrexKeyva commented May 28, 2021

Copy link
Copy Markdown
Contributor

#38828...?

npm-robot changed the title deps(cli): upgrade npm to 7.15.0 deps: upgrade npm to 7.15.0 May 28, 2021
darcyclarke mentioned this pull request May 28, 2021
Closed

darcyclarke commented May 28, 2021

Copy link
Copy Markdown
Member

@VoltrexMaster #38828 (comment)

darcyclarke commented May 28, 2021

Copy link
Copy Markdown
Member

Of note, @gimli01 is looking into why this automation has a larger diff then @lpinca's PR; As noted in #38828 (comment), this PR was generated via a GitHub Action that will be kicked off immediately after our releases going forward (ref. https://github.com/npm/cli/blob/latest/.github/workflows/create-cli-deps-pr.yml)

Ayase-252 commented May 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Maybe it need sync with latest master? I saw This branch is 1 commit ahead, 1359 commits behind nodejs:master. in https://github.com/npm/node/tree/npm-7.15.0

aduh95 commented May 28, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

There is a no-bot but our bots policy in Node.js's repos:

Accounts that are reasonably believed to be bots (other than bots authorized by both TSC and CommComm) are subject to immediate Blocking.

Does @npm-robot fits in the authorized category? Would it be possible to link to an issue where its introduction has been discussed?

ruyadorno commented May 31, 2021

Copy link
Copy Markdown
Member

There is a no-bot but our bots policy in Node.js's repos:

Accounts that are reasonably believed to be bots (other than bots authorized by both TSC and CommComm) are subject to immediate Blocking.

Hi @aduh95 thank you so much for bringing that up, personally I wasn't aware of the existence of that policy when I first discussed the npm-robot PR strategy but I can totally see the reason for having it 😊

That said, my personal interpretation of the policy is that it's in place to avoid spamming and other unwanted behavior. That wouldn't be the case here. This robot is clearly performing a legitimate task, helping us better integrate npm cli releases timely into node releases.

Does @npm-robot fits in the authorized category? Would it be possible to link to an issue where its introduction has been discussed?

Could you please help us bring the subject to a future TSC meeting agenda? Given that we have that policy in place I believe the best way to move forward is to make sure get an explicit approval. 🙏

aduh95 added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 31, 2021
ruyadorno mentioned this pull request May 31, 2021
Closed

ruyadorno commented May 31, 2021

Copy link
Copy Markdown
Member

actually, let me create an issue instead and close this PR as I want to make sure we clean things up in the update npm side of things 😊

Opened: #38879 so that we can continue the conversation there.

ruyadorno closed this May 31, 2021
ruyadorno removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label May 31, 2021
wraithgar deleted the npm-7.15.0 branch June 26, 2025 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL