doc: standardize on "Long Term Support" - #38841
Merged
Trott merged 2 commits intoMay 31, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
DerekNonGeneric
approved these changes
May 29, 2021
bl-ue
approved these changes
May 29, 2021
targos
approved these changes
May 29, 2021
Copy link
Copy Markdown
Contributor
|
Yeah sounds good, thank you for making the changes. I added another comment to the discussion that we having before. I'm listing the link for anybody who wants to understand the logic behind the changes: #38839 |
Sorry, something went wrong.
Trott
added a commit
to Trott/remark-preset-lint-node
that referenced
this pull request
May 29, 2021
lpinca
approved these changes
May 29, 2021
RaisinTen
approved these changes
May 30, 2021
cjihrig
approved these changes
May 30, 2021
jasnell
approved these changes
May 31, 2021
mhdawson
approved these changes
May 31, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Use "Long Term Support" rather than "long term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Use "Long Term Support" rather than "Long-term support". Refs: nodejs#38839 (comment) PR-URL: nodejs#38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Copy link
Copy Markdown
Contributor
|
Why does GH say that the PR was merged, rather than closed? It does that sometimes, but it's not clear to me why. 🤔 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
If people follow the general procedure for this repo, it will end up Closed. However, there is an optional step that I always take where, before pushing the change to the master branch, you force-push it to the PR branch. Some users don't allow project collaborators to force push to their branches, but most do (as it's the default in GitHub--you have to uncheck a box when opening the pull request to prevent it). So if that works, it ends up being purple and merged, which people seem to appreciate and which I gather affects some tooling and GitHub stats in a positive way. |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Jun 1, 2021
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 1, 2021
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
Trott
added a commit
to nodejs/remark-preset-lint-node
that referenced
this pull request
Jun 2, 2021
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 16, 2021
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 19, 2021
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Use "Long Term Support" rather than "long term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Jul 20, 2021
Use "Long Term Support" rather than "Long-term support". Refs: #38839 (comment) PR-URL: #38841 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
Merged
Marlyfleitas
added a commit
to Marlyfleitas/Node-remark-preset-lint
that referenced
this pull request
Aug 26, 2022
patrickm68
added a commit
to patrickm68/Node-preset-lint
that referenced
this pull request
Sep 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll add a lint rule to the Node.js remark lint preset.