FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix typos by bl-ue · Pull Request #38845 · nodejs/node · GitHub

/ node Public

src: fix typos - #38845

Merged
aduh95 merged 1 commit into
nodejs:masterfrom
bl-ue:fix-src-typos
Jun 1, 2021
ConversationCommits (1)ChecksFiles changed
Merged

src: fix typos#38845
aduh95 merged 1 commit into
nodejs:masterfrom
bl-ue:fix-src-typos

Conversation

bl-ue commented May 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

github-actions Bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 29, 2021
antsmartian added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 31, 2021
src: fix typos
11e77e4 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

aduh95 commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

Landed in 11e77e4

aduh95 merged commit 11e77e4 into nodejs:master Jun 1, 2021
bl-ue deleted the fix-src-typos branch June 1, 2021 12:23

bl-ue commented Jun 1, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

GH says the PR was merged, not closed. @aduh95 any idea why?

danielleadams pushed a commit that referenced this pull request Jun 1, 2021
src: fix typos
f25cd4f 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
danielleadams mentioned this pull request Jun 1, 2021
Merged

aduh95 commented Jun 1, 2021

Copy link
Copy Markdown
Contributor

GH says the PR was merged, not closed. @aduh95 any idea why?

I force-pushed the amended commit to your branch before pushing it to master so the GitHub UI shows merged status. Sorry if that's an inconvenience for you, FYI you can disable this by unchecking Allow edits and access to secrets by maintainers when creating the PR.

bl-ue commented Jun 1, 2021

Copy link
Copy Markdown
Contributor Author

Ah, I see! That makes sense. I guess it's not as nice for the PRs history...but I do like seeing that the PR was merged (because GH saying that it was closed is quite confusing...)

I'll leave that checkbox alone and let you guys keep merging how you like—I don't care much one way or another.

richardlau pushed a commit that referenced this pull request Jul 16, 2021
src: fix typos
cbdef7d 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
src: fix typos
b6acc51 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
src: fix typos
73e199d 
PR-URL: #38845
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
richardlau mentioned this pull request Jul 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
himself65 himself65 approved these changes
RaisinTen RaisinTen approved these changes
+2 more reviewers
antsmartian antsmartian approved these changes
XadillaX XadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL