FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: close fds properly in tests by joyeecheung · Pull Request #38884 · nodejs/node · GitHub

/ node Public

test: close fds properly in tests - #38884

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:close-fd
Closed

test: close fds properly in tests#38884
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:close-fd

Conversation

joyeecheung commented Jun 1, 2021
edited
Loading

Copy link
Copy Markdown
Member

Otherwise the unclosed fd may keep the file open which makes
subsequent rmdir attempts failed at exit.

#38826 (comment)

github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 1, 2021
Otherwise the unclosed fd may keep the file open which makes
subsequent rmdir attempts failed at exit.

Copy link
Copy Markdown
Member Author

Looks like a duplicate of #38604 , closing..

joyeecheung closed this Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL