FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: dont-land gyp-next PRs on LTS branches by targos · Pull Request #38887 · nodejs/node · GitHub

/ node Public

build: dont-land gyp-next PRs on LTS branches - #38887

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:label-pr-gyp
Closed

build: dont-land gyp-next PRs on LTS branches#38887
targos wants to merge 1 commit into
nodejs:masterfrom
targos:label-pr-gyp

Conversation

targos commented Jun 1, 2021

Copy link
Copy Markdown
Member

gyp-next doesn't support Python 3 anymore so we can't backport its updates.

gyp-next doesn't support Python 3 anymore so we can't backport its updates.
github-actions Bot added the meta Issues and PRs related to the general management of the project. label Jun 1, 2021
aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 1, 2021
targos added a commit that referenced this pull request Jun 3, 2021
gyp-next doesn't support Python 3 anymore so we can't backport its
updates.

PR-URL: #38887
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

targos commented Jun 3, 2021

Copy link
Copy Markdown
Member Author

Landed in 43cba1d

targos closed this Jun 3, 2021
targos deleted the label-pr-gyp branch June 3, 2021 15:27
targos added a commit that referenced this pull request Jun 11, 2021
gyp-next doesn't support Python 3 anymore so we can't backport its
updates.

PR-URL: #38887
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams mentioned this pull request Jun 14, 2021

DeeDeeG commented Jun 23, 2021

Copy link
Copy Markdown
Contributor

gyp-next doesn't support Python 3 anymore so we can't backport its updates.

For the record this should say "Python 2"

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants


Back | FazBrowse Home | New Git URL