build: apply workaround for msbuild 16.10.0 only - #38930
Conversation
Sorry, something went wrong.
Only apply the msbuild target workaround for msbuild 16.10.0 only as that is the version containing the regression and the workaround will still be needed if building with that version even when a newer version of msbuild is available.
Sorry, something went wrong.
|
Why would we like to keep the workaround when 16.10.1 is released? We do not usually support every possible version of required tools. |
Sorry, something went wrong.
|
🤷 We claim to support "Visual Studio >= 2019 with the Windows 10 SDK on a 64-bit host" (https://github.com/nodejs/node/blob/master/BUILDING.md#supported-toolchains) and don't specify it needs to be the latest available VS 2019. For example, the Windows hosts on our Jenkins CI is running msbuild 16.9.0 and hasn't been updated to 16.10.0 (they also run in a configuration where target is already Build and not node so would not run into the original issue anyway). This change would keep the previous behaviour with older msbuild (i.e. anyone who hasn't yet updated to 16.10.0). I'm not too fussed over this so if the consensus is to not bother we can just close. |
Sorry, something went wrong.
Co-authored-by: bl-ue <54780737+bl-ue@users.noreply.github.com>
Only apply the msbuild target workaround for msbuild 16.10.0 only as
that is the version containing the regression and the workaround will
still be needed if building with that version even when a newer version
of msbuild is available.
Refs: dotnet/msbuild#6465
Refs: #38872
Refs: #38873
cc @targos @nodejs/platform-windows