typings: add a few JSDoc typings for child_process - #38951
Closed
raghavken wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
reviewed
Jun 6, 2021
Comment thread
lib/child_process.js
| /** | ||
| * Spawns a new Node.js insatnce | ||
| * using the execPath of the parent process | ||
| * @param {string} modulePath |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
It seems this is lacking a definition for the optional parameters (args and options).
Sorry, something went wrong.
Comment thread
lib/child_process.js
| /** | ||
| * Spawns the new specified excutable file | ||
| * as a new process | ||
| * @param {string} file |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Ditto here (args, options, and callback).
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Just made another commit should fix the mistakes I made. Thank you for reviewing it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a few JSDoc typings for the child_process lib module.