deps: update V8 to 9.2 by targos · Pull Request #38990 · nodejs/node · GitHub

No description provided.

CI: https://ci.nodejs.org/job/node-test-pull-request/38556/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4038/

13:34:56 + gn gen -v out.gn/s390x.release '--args=is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true'
13:34:56 ERROR at //.gn:18:20: Assignment had no effect.
13:34:56 no_check_targets = [
13:34:56                    ^
13:34:56 You set the variable "no_check_targets" here and it was unused before it went
13:34:56 out of scope.

Looks like we need to adapt the V8 build/test script

I cherry-picked a commit to fix the ARM build.

The error on Windows is the following and still happens on V8 master:

D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(462,31): error C3779: 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers': a function that returns 'auto' cannot be used before it is defined [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(422): message : see declaration of 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(461): message : while compiling class template member function 'v8::internal::Register v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::GetRegisterParameter(int)' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(1771): message : see reference to class template instantiation 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>' being compiled [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(462,31): error C3779: 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers': a function that returns 'auto' cannot be used before it is defined [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(422): message : see declaration of 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::registers' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(461): message : while compiling class template member function 'v8::internal::Register v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>::GetRegisterParameter(int)' [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]
D:\a\node\node\deps\v8\src\codegen\interface-descriptors.h(1771): message : see reference to class template instantiation 'v8::internal::StaticCallInterfaceDescriptor<v8::internal::BigIntToI32PairDescriptor>' being compiled [D:\a\node\node\tools\v8_gypfiles\v8_compiler.vcxproj]

CI: https://ci.nodejs.org/job/node-test-pull-request/38557/

Error on some of the Linux hosts:

14:46:45   touch /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-last-latest-x64/out/Release/obj.target/tools/v8_gypfiles/v8_compiler_for_mksnapshot.stamp
14:46:45 make[2]: execvp: printf: Argument list too long
14:46:56 make[2]: *** [tools/v8_gypfiles/v8_base_without_compiler.target.mk:1007: /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine-last-latest-x64/out/Release/obj.target/tools/v8_gypfiles/libv8_base_without_compiler.a] Error 127

13:34:56 + gn gen -v out.gn/s390x.release '--args=is_component_build=false is_debug=false use_goma=false goma_dir="None" use_custom_libcxx=false v8_target_cpu="s390x" target_cpu="s390x" v8_enable_backtrace=true'
13:34:56 ERROR at //.gn:18:20: Assignment had no effect.
13:34:56 no_check_targets = [
13:34:56                    ^
13:34:56 You set the variable "no_check_targets" here and it was unused before it went
13:34:56 out of scope.

Looks like we need to adapt the V8 build/test script

@miladfarca @john-yan Is this something we've seen upstream in V8 for PPC/s390x? Do we need a gn update?

@richardlau I have tried both these gn versions on V8 branch-heads/9.2, using the same arguments and it runs successfully:

1824 (5da62d5e)
and
1912 (d3fe8f4d)

Definitely try updating gn first if its older than above versions.

FTR we're currently on

1618 (f0a6900)

for PPC and

1620 (570aaed)

for s390x. I'll try to get them updated.

I opened a CL to fix the Windows build: https://chromium-review.googlesource.com/c/v8/v8/+/2964095

CI: https://ci.nodejs.org/job/node-test-pull-request/38650/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/4060/

Other error on Windows (debug):

13:32:35 C:\workspace\node-compile-windows-debug\node\deps\v8\src\compiler\common-operator.h(615,3): error C3615: constexpr function 'v8::internal::compiler::FrameState::FrameState' cannot result in a constant expression [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
13:32:35 C:\workspace\node-compile-windows-debug\node\deps\v8\src\compiler\common-operator.h(620,1): message : failure was caused by call of undefined function or one not declared 'constexpr' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]
13:32:35 C:\workspace\node-compile-windows-debug\node\deps\v8\src\compiler\common-operator.h(620,1): message : see usage of 'v8::internal::compiler::Node::opcode' [C:\workspace\node-compile-windows-debug\node\tools\v8_gypfiles\v8_base_without_compiler.vcxproj]

I've updated the version of gn we're using on Linux ppc64/s390x (nodejs/build#2675 for the Ansible scripts that automate this).

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4065/
(ppc64 and s390x no longer fail due to ERROR at //.gn:18:20: Assignment had no effect. error)

s390x built but fails a test:

20:52:11 === mjsunit/tools/tickprocessor ===
20:52:11 --- stderr ---
20:52:11 file="/data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/tools/tickprocessor-test-large.log": Error loading file
20:52:11 --- stdout ---
20:52:11 === testProcessing-Default ===
20:52:11 === testProcessing-SeparateBytecodes ===
20:52:11 === testProcessing-SeparateBaselineHandlers ===
20:52:11 === testProcessing-SeparateIc ===
20:52:11 === testProcessing-IgnoreUnknown ===
20:52:11 === testProcessing-GcState ===
20:52:11 === testProcessing-OnlySummary ===
20:52:11 === testProcessing-FunctionInfo ===
20:52:11 === testProcessing-DefaultLarge ===
20:52:11 /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/tools/tickprocessor.mjs:67: Error: Error loading file
20:52:11     return read(fileName);
20:52:11            ^
20:52:11 Command: /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/s390x.release/d8 --test -e TEST_FILE_NAME="/data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/tools/tickprocessor.mjs" /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/mjsunit.js /data/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/test/mjsunit/tools/tickprocessor.mjs --random-seed=-137790089 --nohard-abort --testing-d8-test-runner

ppc64 also failed the tickprocessor test but also has three crashes
cc @nodejs/platform-ppc

16:33:41 === cctest/test-gc/RunWasmTurbofan_RefTrivialCasts ===
16:33:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/ppc64.release/cctest test-gc/RunWasmTurbofan_RefTrivialCasts --random-seed=-451154066 --nohard-abort --testing-d8-test-runner
16:33:41 exit code: -4 [FFFFFFFC]
16:33:41 --- CRASHED ---
16:33:41 === cctest/test-run-wasm/RunWasmLiftoff_Select_s128_parameters ===
16:33:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/ppc64.release/cctest test-run-wasm/RunWasmLiftoff_Select_s128_parameters --random-seed=-451154066 --nohard-abort --testing-d8-test-runner
16:33:41 exit code: -4 [FFFFFFFC]
16:33:41 --- CRASHED ---
16:33:41 === cctest/test-run-wasm/RunWasmTurbofan_Select_s128_parameters ===
16:33:41 Command: /home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/out.gn/ppc64.release/cctest test-run-wasm/RunWasmTurbofan_Select_s128_parameters --random-seed=-451154066 --nohard-abort --testing-d8-test-runner
16:33:41 exit code: -4 [FFFFFFFC]
16:33:41 --- CRASHED ---

@richardlau PPC failures should be because of not having Simd support on P8, could you cherry pick this and try again: https://chromium-review.googlesource.com/c/v8/v8/+/2927210

test/mjsunit/tools/tickprocessor-test-large.log was added in this CL:
https://chromium-review.googlesource.com/c/v8/v8/+/2784686

Test was skipped on most platforms later on, file should still be present tho:
https://chromium-review.googlesource.com/c/v8/v8/+/2848461

@richardlau PPC failures should be because of not having Simd support on P8, could you cherry pick this and try again: https://chromium-review.googlesource.com/c/v8/v8/+/2927210

Thanks, cherry-picked that one across.
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4067/

test/mjsunit/tools/tickprocessor-test-large.log was added in this CL:
https://chromium-review.googlesource.com/c/v8/v8/+/2784686

Test was skipped on most platforms later on, file should still be present tho:
https://chromium-review.googlesource.com/c/v8/v8/+/2848461

AFAICT V8 9.2.230.10 already contains v8/v8@e1e1220.

That's right, but I'm not sure why tickprocessor-test-large.log is missing in this PR, it does exist on V8 9.2.230.10: https://github.com/v8/v8/blob/cd9bcb6680df93d185eb274c23a2137ce4d44e14/test/mjsunit/tools/tickprocessor-test-large.log

That's right, but I'm not sure why tickprocessor-test-large.log is missing in this PR, it does exist on V8 9.2.230.10: https://github.com/v8/v8/blob/cd9bcb6680df93d185eb274c23a2137ce4d44e14/test/mjsunit/tools/tickprocessor-test-large.log

It's ignored by git due to *.log in deps/v8/.gitignore:

node/deps/v8/.gitignore

Line 7 in a23ac88

*.log

same as in upstream for 9.2.230.10: https://github.com/v8/v8/blob/cd9bcb6680df93d185eb274c23a2137ce4d44e14/.gitignore#L7

I've pushed a fixup commit. Retesting: https://ci.nodejs.org/job/node-test-commit-v8-linux/4069/

Failure on the benchmark machine is not obvious: https://ci.nodejs.org/job/node-test-commit-v8-linux/4069/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

CI: https://ci.nodejs.org/job/node-test-pull-request/38696/

20:12:29 make[2]: execvp: printf: Argument list too long

What can we do about this?

Trying with /std:c++17 on Windows. https://ci.nodejs.org/job/node-test-commit-windows-fanned/43432/
I think the debug build error comes from v8/v8@499f169

Edit: the error remains.

Original commit message: Move DCHECK() in JSCallOrConstructNode ctor into a helper function. As is, the DCHECK() has a #if inside, and MSVC has trouble pre-processing that. Fix this by moving the conditional inside the DCHECK() into a separate helper function. Bug: v8:11760 Change-Id: Ib4ae0fe263029bb426da378afa5b6881557ce652 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919421 Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#74807} Refs: v8/v8@7ff6609 PR-URL: nodejs#38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gtest_prod.h is not enough to build V8's cctests. PR-URL: nodejs#38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

V8 9.2 doesn't emit the "V8.ScriptCompiler" event anymore. Use "V8.GCScavenger" instead. Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

It it's not testing anything useful anymore. Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

V8 had a bug that in certain cases the default microtask queue was drained, and this test relies on the behavior. Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Original commit message: ARM64: VRegister::from_code expected to be constexpr GCC build fails trying to use a non constexpr function from a constexpr function. ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h: In member function 'constexpr v8::internal::DoubleRegister v8::internal::wasm::LiftoffRegister::fp() const': ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h:286:71: error: call to non-'constexpr' function 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)' 286 | return DoubleRegister::from_code(code_ - kAfterMaxLiftoffGpRegCode); | ^ In file included from ../chromium-92.0.4503.0/v8/src/codegen/register-arch.h:16, from ../chromium-92.0.4503.0/v8/src/deoptimizer/translation-array.h:8, from ../chromium-92.0.4503.0/v8/src/objects/code.h:10, from ../chromium-92.0.4503.0/v8/src/codegen/reloc-info.h:10, from ../chromium-92.0.4503.0/v8/src/codegen/assembler.h:47, from ../chromium-92.0.4503.0/v8/src/codegen/assembler-arch.h:8, from ../chromium-92.0.4503.0/v8/src/codegen/turbo-assembler.h:12, from ../chromium-92.0.4503.0/v8/src/codegen/macro-assembler.h:8, from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.h:13, from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.cc:5: ../chromium-92.0.4503.0/v8/src/codegen/arm64/register-arm64.h:416:20: note: 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)' declared here 416 | static VRegister from_code(int code) { | ^~~~~~~~~ Bug: chromium:819294 Change-Id: Ia19ea90f3f666702d32c90e147af17dcda7e08a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929805 Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#74889} Refs: v8/v8@3d24b3a Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Original commit message: [codegen] Move definition of GetRegisterParameter to inline header This fixes compilation of V8 in Node.js with Visual Studio 2019. Without this change, MSVC errors with C3779 (a function that returns 'auto' cannot be used before it is defined) on the `static constexpr auto registers()` method. Bug: v8:11420 Change-Id: Id545199e2cdc10c8560031fb5950ec1171e5d554 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2964095 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#75173} Refs: v8/v8@71e8f8b Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Original commit message: [wasm-simd] Skip tests which require Simd enabled These tests require Simd enabled which causes failures on machines without the support. They are already skipped on Mips: https://crrev.com/c/2841887 Change-Id: I4b9a9bb3cb208a0e9aa12dc135393bc515ad766e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2927210 Reviewed-by: Zhi An Ng <zhin@chromium.org> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#74891} Refs: v8/v8@9862992 Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Original commit message: Mark Node::opcode() and Operator::opcode() as constexpr. Without the explicit constexpr keyword, Clang seems to be able to treat these methods as constexpr, whereas MSVC will not. Bug: v8:11760 Change-Id: I9f6492f38fb50dcaf7a4f09da0bd79c0da6a50eb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2912916 Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#74791} Refs: v8/v8@a5cea1b Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Original commit message: Move DCHECK() in JSCallOrConstructNode ctor into a helper function. As is, the DCHECK() has a #if inside, and MSVC has trouble pre-processing that. Fix this by moving the conditional inside the DCHECK() into a separate helper function. Bug: v8:11760 Change-Id: Ib4ae0fe263029bb426da378afa5b6881557ce652 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2919421 Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#74807} Refs: v8/v8@7ff6609 Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

gtest_prod.h is not enough to build V8's cctests. Backport-PR-URL: #39470 PR-URL: #38990 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jun 10, 2021

targos changed the title deps: update V8 to 92 deps: update V8 to 9.2 Jun 10, 2021

github-actions Bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 10, 2021

targos added the wip Issues and PRs that are still a work in progress. label Jun 10, 2021

targos mentioned this pull request Jun 15, 2021

Node.js Technical Steering Committee (TSC) Meeting 2021-06-17 nodejs/TSC#1040

Closed

richardlau mentioned this pull request Jun 16, 2021

ansible: build gn from source on Linux PPC/s390x nodejs/build#2675

Merged

targos added the backport-open-v16.x label Jul 20, 2021

targos mentioned this pull request Jul 20, 2021

[v16.x-backport] deps: update V8 to 9.2 #39470

Closed

BethGriggs mentioned this pull request Jul 26, 2021

v16.6.0 proposal #39534

Merged

ljharb mentioned this pull request Jul 30, 2021

doc: add String.prototype.at and %TypedArray%.prototype.at #39583

Closed

targos mentioned this pull request Sep 6, 2021

v16.9.0 release proposal #40011

Merged

danielleadams mentioned this pull request Oct 4, 2021

v16.11.0 release proposal #40319

Merged

targos mentioned this pull request Nov 26, 2021

v17.2.0 release proposal #40983

Merged

deps: update V8 to 9.2 by targos · Pull Request #38990 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: update V8 to 9.2 - #38990

deps: update V8 to 9.2#38990targos wants to merge 29 commits intonodejs:masternodejs/node:masterfrom targos:v8-92targos/node:v8-92Copy head branch name to clipboard

Conversation

targos commented Jun 10, 2021

Uh oh!

nodejs-github-bot commented Jun 10, 2021 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 10, 2021

Uh oh!

nodejs-github-bot commented Jun 10, 2021

Uh oh!

targos commented Jun 10, 2021

Uh oh!

richardlau commented Jun 10, 2021

Uh oh!

miladfarca commented Jun 10, 2021

Uh oh!

richardlau commented Jun 10, 2021

Uh oh!

targos commented Jun 15, 2021

Uh oh!

nodejs-github-bot commented Jun 16, 2021 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 16, 2021

Uh oh!

richardlau commented Jun 16, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Jun 16, 2021

Uh oh!

richardlau commented Jun 16, 2021

Uh oh!

miladfarca commented Jun 16, 2021

Uh oh!

richardlau commented Jun 17, 2021

Uh oh!

miladfarca commented Jun 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richardlau commented Jun 17, 2021

Uh oh!

targos commented Jun 17, 2021

Uh oh!

nodejs-github-bot commented Jun 19, 2021

Uh oh!

targos commented Jun 20, 2021

Uh oh!

targos commented Jun 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

deps: update V8 to 9.2#38990
targos wants to merge 29 commits into
nodejs:masterfrom
targos:v8-92

nodejs-github-bot commented Jun 10, 2021 •
edited by targos
Loading

targos commented Jun 10, 2021 •
edited
Loading

nodejs-github-bot commented Jun 16, 2021 •
edited by targos
Loading

richardlau commented Jun 16, 2021 •
edited
Loading

miladfarca commented Jun 17, 2021 •
edited
Loading

targos commented Jun 20, 2021 •
edited
Loading