FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix typo in test-http2-invalidheaderfield.js by eltociear · Pull Request #39021 · nodejs/node · GitHub

/ node Public

test: fix typo in test-http2-invalidheaderfield.js - #39021

Closed
eltociear wants to merge 1 commit into
nodejs:masterfrom
eltociear:patch-6
Closed

test: fix typo in test-http2-invalidheaderfield.js#39021
eltociear wants to merge 1 commit into
nodejs:masterfrom
eltociear:patch-6

Conversation

Copy link
Copy Markdown
Contributor

Psuedo -> Pseudo

github-actions Bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jun 13, 2021
RaisinTen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2021

nodejs-github-bot commented Jun 13, 2021
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jun 13, 2021
jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 14, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

jasnell commented Jun 14, 2021

Copy link
Copy Markdown
Member

Landed in 7e99dbc

jasnell closed this Jun 14, 2021
jasnell pushed a commit that referenced this pull request Jun 14, 2021
Psuedo -> Pseudo

PR-URL: #39021
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 15, 2021
Psuedo -> Pseudo

PR-URL: #39021
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Jun 15, 2021
danielleadams pushed a commit that referenced this pull request Jun 17, 2021
Psuedo -> Pseudo

PR-URL: #39021
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Copy link
Copy Markdown
Member

The test being fixed was added by a semver-major PR (#33161) so marking as dont-land-on-v14.x.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL