FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove references to deleted freenode channels by devsnek · Pull Request #39047 · nodejs/node · GitHub

/ node Public

doc: remove references to deleted freenode channels - #39047

Merged
devsnek merged 1 commit into
masterfrom
rip-freenode
Jun 17, 2021
ConversationCommits (1)ChecksFiles changed
Merged

doc: remove references to deleted freenode channels#39047
devsnek merged 1 commit into
masterfrom
rip-freenode

Conversation

devsnek commented Jun 15, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Refs nodejs/TSC#1031

cc @nodejs/tsc @nodejs/build

github-actions Bot added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Jun 15, 2021
mcollina approved these changes Jun 15, 2021
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

mhdawson approved these changes Jun 16, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson commented Jun 16, 2021

Copy link
Copy Markdown
Member

I'd propose a fast track for this

benjamingr added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 16, 2021

github-actions Bot commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @benjamingr. Please 👍 to approve.

bnb commented Jun 16, 2021

Copy link
Copy Markdown
Contributor

If this lands, I’d assume nodejs/nodejs.org#3923 or some variant should also probably land too.

gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2021

github-actions Bot commented Jun 17, 2021

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/39047
✔  Done loading data for nodejs/node/pull/39047
----------------------------------- PR info ------------------------------------
Title      doc: remove references to deleted freenode channels (#39047)
Author     devsnek  (@devsnek)
Branch     devsnek:rip-freenode -> nodejs:master
Labels     doc, fast-track, meta
Commits    1
 - doc: remove references to deleted freenode channels
Committers 1
 - Gus Caplan 
PR-URL: https://github.com/nodejs/node/pull/39047
Reviewed-By: Robert Nagy 
Reviewed-By: Mary Marchini 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Michael Dawson 
Reviewed-By: Zijian Liu 
Reviewed-By: Khaidi Chu 
Reviewed-By: Jiawen Geng 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/39047
Reviewed-By: Robert Nagy 
Reviewed-By: Mary Marchini 
Reviewed-By: Matteo Collina 
Reviewed-By: Tobias Nießen 
Reviewed-By: Colin Ihrig 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Luigi Pinca 
Reviewed-By: Joyee Cheung 
Reviewed-By: Michael Dawson 
Reviewed-By: Zijian Liu 
Reviewed-By: Khaidi Chu 
Reviewed-By: Jiawen Geng 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 15 Jun 2021 20:38:28 GMT
   ✔  Approvals: 12
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684466041
   ✔  - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684480431
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684510273
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684531260
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-684663596
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/39047#pullrequestreview-685131502
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/39047#pullrequestreview-685141388
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-685361956
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/39047#pullrequestreview-685544629
   ✔  - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/39047#pullrequestreview-685813419
   ✔  - Khaidi Chu (@XadillaX): https://github.com/nodejs/node/pull/39047#pullrequestreview-685829599
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/39047#pullrequestreview-686087441
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/945925856

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Jun 17, 2021
doc: remove references to deleted freenode channels
e3ba960 
PR-URL: #39047
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
devsnek merged commit e3ba960 into master Jun 17, 2021
devsnek deleted the rip-freenode branch June 17, 2021 12:45

devsnek commented Jun 17, 2021

Copy link
Copy Markdown
Member Author

landed in e3ba960

danielleadams pushed a commit that referenced this pull request Jun 21, 2021
doc: remove references to deleted freenode channels
dce256b 
PR-URL: #39047
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
danielleadams mentioned this pull request Jun 21, 2021
Merged
richardlau mentioned this pull request Jun 23, 2021
Closed
bnb mentioned this pull request Jul 1, 2021
Merged
richardlau pushed a commit that referenced this pull request Jul 19, 2021
doc: remove references to deleted freenode channels
59b2476 
PR-URL: #39047
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
doc: remove references to deleted freenode channels
04032fa 
PR-URL: #39047
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
richardlau mentioned this pull request Jul 20, 2021
Merged
targos removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
benjamingr benjamingr approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
ronag ronag approved these changes
tniessen tniessen approved these changes
gengjiawen gengjiawen approved these changes
joyeecheung joyeecheung approved these changes
Lxxyx Lxxyx approved these changes
+4 more reviewers
joesepi joesepi approved these changes
XadillaX XadillaX approved these changes
mmarchini mmarchini approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL