| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
The commit linter was checking out the PR HEAD commit instead of merge/rebase commit, causing it to fail for any PRs that were not rebased on our default branch.
There was a problem hiding this comment.
If we add more dependencies it means we need to fetch more things, plus this PR unnecessarily increases the complexity of the Action.
Sorry, something went wrong.
I'm confused, this PR doesn't add a dependency, what do you mean by that? |
Sorry, something went wrong.
|
Dependencies in "external" files (as in files that are not the Action file, not actual dependencies). So if we move git log --oneline ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }} | grep -v -e fixup -e squash | awk '{ print $1 }' | xargs npx -q core-validate-commit --no-validate-metadata --tap to a script in tools/actions now we need to download two files instead of one. Furthermore, downloading a file manually when this file will be fetched automatically as part of #39121 is unnecessary extra work that doesn't add robustness to the action, just complexity. |
Sorry, something went wrong.
|
I agree that curl command does make the action more fragile. If the script is made to work around merging (which clearly different from squashing, please blame my insufficient knowledge of git on that one), I'm closing this in favor of your PR. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Alternative to #39121.
The commit linter was checking out the PR HEAD commit instead of
merge/rebase commit, causing it to fail for any PRs that were not
rebased on our default branch.