build: restore libplatform headers in distribution - #39288
Closed
jeroen wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Headers considered non-essential were removed in #37570, however the libplatform API is actualy needed (and used) by external software initiaing the v8 engine, see for example https://chromium.googlesource.com/v8/v8/+/refs/heads/main/samples/hello-world.cc
Copy link
Copy Markdown
Member
|
cc @nodejs/embedders |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
It's always possible for you to have your own copy of these headers. That said, as the one who removed them and who does most of the work related to V8 updates, I'm okay with this change. The libplatform headers rarely have breaking changes. |
Sorry, something went wrong.
targos
approved these changes
Jul 6, 2021
richardlau
approved these changes
Jul 6, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
mhdawson
approved these changes
Jul 7, 2021
mhdawson
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
cjihrig
approved these changes
Jul 8, 2021
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
Headers considered non-essential were removed in #37570, however the libplatform API is actualy needed (and used) by external software initiaing the v8 engine, see for example: https://chromium.googlesource.com/v8/v8/+/refs/heads/main/samples/hello-world.cc PR-URL: #39288 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
Headers considered non-essential were removed in #37570, however the libplatform API is actualy needed (and used) by external software initiaing the v8 engine, see for example: https://chromium.googlesource.com/v8/v8/+/refs/heads/main/samples/hello-world.cc PR-URL: #39288 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jul 14, 2021
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Jul 15, 2021
* chore: bump node in DEPS to v16.4.2 * chore: update patches * ci: run main and remote woa tests separately * chore: bump node in DEPS to v16.5.0 * build: restore libplatform headers in distribution nodejs/node#39288 * build: pass directory instead of list of files to js2c.py nodejs/node#39069 * chore: various BoringSSL/OpenSSL upstreams - nodejs/node#39136 - nodejs/node#39138 - nodejs/node#39054 * test: move debugger test case to parallel nodejs/node#39300 * chore: fixup patch indices * build: pass directory instead of list of files to js2c.py nodejs/node#39069 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
* chore: bump node in DEPS to v16.4.2 * chore: update patches * ci: run main and remote woa tests separately * chore: bump node in DEPS to v16.5.0 * build: restore libplatform headers in distribution nodejs/node#39288 * build: pass directory instead of list of files to js2c.py nodejs/node#39069 * chore: various BoringSSL/OpenSSL upstreams - nodejs/node#39136 - nodejs/node#39138 - nodejs/node#39054 * test: move debugger test case to parallel nodejs/node#39300 * chore: fixup patch indices * build: pass directory instead of list of files to js2c.py nodejs/node#39069 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I maintain libnode/v8 bindings for the R programming language, which depend on libnode on most Linux distro's, e.g. r-cran-v8 in Debian/Ubuntu and R-V8 in Fedora.
Headers considered non-essential were removed in #37570, however the libplatform API is actually needed by external software initiating the v8 engine. See for example the upstream v8 hello world example: https://chromium.googlesource.com/v8/v8/+/refs/heads/main/samples/hello-world.cc
I have also asked upstream v8 if the API in question could maybe be moved to the top level v8-* headers, but they have not responded.
I hope it can be reconsidered to ship these headers, otherwise it will no longer be possible for us to build bindings for libnode, which would be very unfortunate, because they are widely used.