FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: server check Host header in request, to meet RFC 7230 5.4 requirement by wwwzbwcom · Pull Request #39322 · nodejs/node · GitHub

/ node Public

http: server check Host header in request, to meet RFC 7230 5.4 requirement - #39322

Closed
wwwzbwcom wants to merge 5 commits into
nodejs:mainfrom
wwwzbwcom:master
ConversationCommits (5)ChecksFiles changed
Closed

http: server check Host header in request, to meet RFC 7230 5.4 requirement#39322
wwwzbwcom wants to merge 5 commits into
nodejs:mainfrom
wwwzbwcom:master

Conversation

wwwzbwcom commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

Relate issues: #3094 #39033

According to RFC 2730 5.4 https://datatracker.ietf.org/doc/html/rfc7230#section-5.4:
A server MUST respond with a 400 (Bad Request) status code to any HTTP/1.1 request message that lacks a Host header field and to any request message that contains more than one Host header field or a Host header field with an invalid field-value.

github-actions Bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 9, 2021

himself65 commented Jul 9, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

could you please add some test cases?

Under test/parellel/

wwwzbwcom commented Jul 9, 2021

Copy link
Copy Markdown
Contributor Author

could you please add some test cases?

Under test/parellel/

Working on it.

Also, I wonder how to increamental build under windows, every time I run test or build with ./vcbuild.bat, it compile whole program.

mscdex reviewed Jul 9, 2021
View reviewed changes
Comment thread lib/_http_server.js Outdated
wwwzbwcom requested a review from mscdex July 15, 2021 08:51
wwwzbwcom requested a review from jasnell August 14, 2021 07:06

wwwzbwcom commented Aug 31, 2021

Copy link
Copy Markdown
Contributor Author

Is there any additional work needed for this PR?

Ayase-252 commented Oct 7, 2021

Copy link
Copy Markdown
Member

@wwwzbwcom I'm sorry for this PR got staled..

It seems that it is conflict with current master branch. Would you want to resolve it? After that, I would ping http team for further reviewing.

marco-ippolito mentioned this pull request Nov 23, 2022
Closed

aduh95 commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

Hey, this would need a rebase to solve the git conflicts.

marco-ippolito commented Nov 2, 2024

Copy link
Copy Markdown
Member

Superseded by #45597

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mscdex Awaiting requested review from mscdex
jasnell Awaiting requested review from jasnell

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL