streams: implement TextEncoderStream and TextDecoderStream - #39347
Closed
jasnell wants to merge 3 commits into
Closed
streams: implement TextEncoderStream and TextDecoderStream#39347jasnell wants to merge 3 commits into
jasnell wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
targos
reviewed
Jul 11, 2021
Comment thread
test/parallel/test-whatwg-webstreams-encoding.js
Outdated
aduh95
reviewed
Jul 11, 2021
Comment thread
lib/internal/webstreams/encoding.js
Outdated
jasnell
force-pushed
the
encoding-webstreams
branch
from
ca757bd to
1f4b37c
Compare
July 13, 2021 18:00
Experimental as part of the web streams implementation Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
encoding-webstreams
branch
from
1f4b37c to
2e2d7cd
Compare
July 13, 2021 18:06
aduh95
approved these changes
Jul 13, 2021
Comment thread
doc/api/webstreams.md
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
mcollina
approved these changes
Jul 14, 2021
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
jasnell
added a commit
that referenced
this pull request
Jul 14, 2021
Experimental as part of the web streams implementation Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39347 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 17, 2021
Experimental as part of the web streams implementation Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39347 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Jul 29, 2021
Experimental as part of the web streams implementation Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #39347 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental as part of the web streams implementation (technically these are part of the same encoding spec as TextDecoder and TextEncoder, but make sense to keep bundled up with the require('web/stream') exports.
Still TODO: Enable the relevant web platform tests
Signed-off-by: James M Snell jasnell@gmail.com