test: add NumberFormat resolvedOptions test - #39401
Closed
richardlau wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Add a regression test for NumberFormat resolvedOptions.
targos
approved these changes
Jul 15, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
cjihrig
approved these changes
Jul 16, 2021
tniessen
approved these changes
Jul 16, 2021
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @targos. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Small test addition, blocking a backport... fast-track? |
Sorry, something went wrong.
targos
pushed a commit
to targos/node
that referenced
this pull request
Jul 20, 2021
Add a regression test for NumberFormat resolvedOptions. PR-URL: nodejs#39401 Refs: nodejs#39050 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a regression test for NumberFormat resolvedOptions.
Refs: #39050
I'd like to land this on v14.x-staging together with/as part of #39051. We now have a CI job that builds Node.js dynamically linked against the minimum supported level of ICU but the job isn't failing on v14.x-staging for the problem reported in #39050 as we don't have the coverage.