stream: fix toWeb typo - #39496
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/streams |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Maybe the naming could be improved? It's really hard (impossible?) to tell difference between e.g. newStreamReadableFromReadableStream and also know which one does what. I had to literally go into the implementation check that it looks like it's working on a node stream and copy/paste the function name to make sure I got the right one. |
Sorry, something went wrong.
mcollina
approved these changes
Jul 23, 2021
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
benjamingr
approved these changes
Jul 24, 2021
tniessen
approved these changes
Jul 24, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
ronag
added a commit
that referenced
this pull request
Jul 25, 2021
PR-URL: #39496 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.