module: add some typings to internal/modules/esm/resolve - #39504
Merged
aduh95 merged 1 commit intoAug 2, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Jul 26, 2021
targos
approved these changes
Aug 1, 2021
Copy link
Copy Markdown
Member
|
Nit: you can use the typings subsystem. |
Sorry, something went wrong.
Mesteery
reviewed
Aug 1, 2021
Mesteery
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
nits
Sorry, something went wrong.
Comment thread
lib/internal/modules/esm/resolve.js
Outdated
Comment thread
lib/internal/modules/esm/resolve.js
Outdated
PR-URL: nodejs#39504 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
force-pushed
the
fix-resolve-typings
branch
from
e5fa661 to
45f98fc
Compare
August 2, 2021 08:22
Copy link
Copy Markdown
Contributor
Author
I tried and got ✖ 0:0 Invalid subsystem: "typings" subsystem upon landing. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
You probably have an outdated version of node-core-utils |
Sorry, something went wrong.
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39504 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.