FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

webstream: convert premature close to AbortError by ronag · Pull Request #39524 · nodejs/node · GitHub

/ node Public

webstream: convert premature close to AbortError - #39524

Closed
ronag wants to merge 5 commits into
nodejs:masterfrom
nxtedition:web-abort
ConversationCommits (5)ChecksFiles changed
Closed

webstream: convert premature close to AbortError#39524
ronag wants to merge 5 commits into
nodejs:masterfrom
nxtedition:web-abort

Conversation

ronag commented Jul 26, 2021

Copy link
Copy Markdown
Member

AbortError is a more "web" align alternative to
ERR_STREAM_PREMATURE_CLOSE.

webstream: convert premature close to AbortError
f024765 
AbortError is a more "web" align alternative to
ERR_STREAM_PREMATURE_CLOSE.
ronag requested a review from jasnell July 26, 2021 07:32
ronag added stream Issues and PRs related to the stream subsystem. web streams labels Jul 26, 2021
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 26, 2021
aduh95 reviewed Jul 26, 2021
View reviewed changes
Comment thread lib/internal/webstreams/adapters.js Outdated
Update lib/internal/webstreams/adapters.js
18ba68a 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
ronag requested a review from aduh95 July 26, 2021 14:15
ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2021

nodejs-github-bot commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39276/

ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jul 26, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2021

nodejs-github-bot commented Jul 26, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39288/

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 27, 2021

nodejs-github-bot commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39293/

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 28, 2021

nodejs-github-bot commented Jul 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39308/

ronag commented Jul 28, 2021

Copy link
Copy Markdown
Member Author

Landed in 3f0b623

ronag closed this Jul 28, 2021
ronag added a commit that referenced this pull request Jul 28, 2021
stream: convert premature close to AbortError
3f0b623 
AbortError is a more "web" align alternative to
ERR_STREAM_PREMATURE_CLOSE.

PR-URL: #39524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

aduh95 commented Jul 28, 2021

Copy link
Copy Markdown
Contributor

What should be the semverness of this PR? Changing error code is usually semver-major, but maybe semver-minor is fine since WHATWG streams are still experimental.
Also adding don't land labels as I beleive WHATWG streams are not available on LTS release lines, please remove them if that's not correct.

aduh95 added dont-land-on-v12.x semver-minor PRs that contain new features and should be released in the next minor version. labels Jul 28, 2021

jasnell commented Jul 28, 2021

Copy link
Copy Markdown
Member

Web streams are experimental so there is no semver status.

aduh95 removed the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 28, 2021

targos commented Aug 22, 2021

Copy link
Copy Markdown
Member

Depends on #39134

BethGriggs mentioned this pull request Oct 14, 2021
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. stream Issues and PRs related to the stream subsystem. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL