FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf_hooks: fix performance timeline wpt failures by legendecas · Pull Request #39532 · nodejs/node · GitHub

/ node Public

perf_hooks: fix performance timeline wpt failures - #39532

Closed
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:perf_hooks/wpt
ConversationCommits (1)ChecksFiles changed
Closed

perf_hooks: fix performance timeline wpt failures#39532
legendecas wants to merge 1 commit into
nodejs:masterfrom
legendecas:perf_hooks/wpt

Conversation

legendecas commented Jul 26, 2021

Copy link
Copy Markdown
Member

The WPT test runner is unexpectedly running with user-timing tests instead of performance-timeline.

legendecas added the perf_hooks Issues and PRs related to the implementation of the Performance Timing API. label Jul 26, 2021
legendecas marked this pull request as draft July 26, 2021 15:46
legendecas marked this pull request as ready for review July 26, 2021 15:55
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 27, 2021

nodejs-github-bot commented Jul 27, 2021 •
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39298/

  • not ok 3099 report/test-report-fatal-error

nodejs-github-bot commented Jul 28, 2021 •
edited by legendecas
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39304/

  • not ok 1480 parallel/test-https-set-timeout-server

legendecas mentioned this pull request Jul 29, 2021
Closed

nodejs-github-bot commented Jul 29, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39350/ 💚

legendecas added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jul 30, 2021
jasnell pushed a commit that referenced this pull request Jul 30, 2021
perf_hooks: fix performance timeline wpt failures
a27d245 
PR-URL: #39532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>

jasnell commented Jul 30, 2021

Copy link
Copy Markdown
Member

Landed in a27d245

jasnell closed this Jul 30, 2021
legendecas deleted the perf_hooks/wpt branch July 30, 2021 14:55
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
perf_hooks: fix performance timeline wpt failures
b37575b 
PR-URL: #39532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
danielleadams mentioned this pull request Aug 16, 2021
Merged
luketaher mentioned this pull request Sep 4, 2024
Closed
skyclouds2001 mentioned this pull request Nov 11, 2024
Merged
henriquejsza mentioned this pull request May 17, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
XadillaX XadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL