stream: readableDidRead if data has been read - #39543
Closed
ronag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Merged
Copy link
Copy Markdown
Member
Author
|
@nodejs/streams |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Actually, #39520 implements 2 as Readable.bodyUsed so maybe we don't need to do anything? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'm probably good at leaving things as is and have bodyUsed as 2. Leaving this open for now for visibility. @nodejs/streams if you have seen this and have nothing further to add please just 👍 and I'll close this after a few days. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only readableDidRead if there actually has been data read.
We have a slight conflict of use case here:
1, If resume(), read(), pipe() has been called or 'data' or 'readable' listener exists.
2, If read() has returned data or 'end' or 'data' has been emitted.
Do we need two separate properties and if so what should they be called?
readableDidRead, readableDisturbed, readableUsed or readableReading?
If we only want/need one of them I would prefer 2.