FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

perf_hooks: fix PerformanceObserver gc crash by jasnell · Pull Request #39550 · nodejs/node · GitHub

/ node Public

perf_hooks: fix PerformanceObserver gc crash - #39550

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:fix-perfobserver-gc-crash
ConversationCommits (1)ChecksFiles changed
Closed

perf_hooks: fix PerformanceObserver gc crash#39550
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:fix-perfobserver-gc-crash

Conversation

jasnell commented Jul 27, 2021

Copy link
Copy Markdown
Member

Signed-off-by: James M Snell jasnell@gmail.com
Fixes: #39548

jasnell changed the title perf: fix PerformanceObserver gc crash perf_hooks: fix PerformanceObserver gc crash Jul 27, 2021
perf_hooks: fix PerformanceObserver gc crash
403f34b 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: nodejs#39548
jasnell force-pushed the fix-perfobserver-gc-crash branch from 6886f54 to 403f34b Compare July 27, 2021 17:08

This comment has been minimized.

Sign in to view
jasnell mentioned this pull request Jul 27, 2021
Closed
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 27, 2021

nodejs-github-bot commented Jul 28, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39317/

nodejs-github-bot commented Aug 1, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39399/

legendecas added perf_hooks Issues and PRs related to the implementation of the Performance Timing API. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Aug 2, 2021

legendecas commented Aug 2, 2021

Copy link
Copy Markdown
Member

Landed in afabd14

legendecas closed this Aug 2, 2021
legendecas removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 2, 2021
legendecas pushed a commit that referenced this pull request Aug 2, 2021
perf_hooks: fix PerformanceObserver gc crash
afabd14 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #39548

PR-URL: #39550
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
perf_hooks: fix PerformanceObserver gc crash
016b7ba 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: #39548

PR-URL: #39550
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
danielleadams mentioned this pull request Aug 16, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bengl bengl approved these changes
legendecas legendecas approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PerformanceObserver 'gc' crash with multiple observers

5 participants

Back | FazBrowse Home | New Git URL