FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v14.x] deps: upgrade npm to 6.14.14 by darcyclarke · Pull Request #39553 · nodejs/node · GitHub

/ node Public

[v14.x] deps: upgrade npm to 6.14.14 - #39553

Closed
darcyclarke wants to merge 1 commit into
nodejs:v14.x-stagingfrom
npm:npm-6.14.14
ConversationCommits (1)ChecksFiles changed
Closed

[v14.x] deps: upgrade npm to 6.14.14#39553
darcyclarke wants to merge 1 commit into
nodejs:v14.x-stagingfrom
npm:npm-6.14.14

Conversation

darcyclarke commented Jul 27, 2021

Copy link
Copy Markdown
Member

6.14.14 (2021-07-27)

DEPENDENCIES

github-actions Bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jul 27, 2021
darcyclarke mentioned this pull request Jul 27, 2021
Closed

nodejs-github-bot commented Jul 27, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39301/

richardlau commented Jul 27, 2021

Copy link
Copy Markdown
Member

@nodejs/actions Anyone know why the labelling workflow added dont-land-on-v14.x/dont-land-on-v12.x labels to this PR? Is the workflow picking up the label config from master rather than v14.x-staging?

targos commented Jul 28, 2021

Copy link
Copy Markdown
Member

Is the workflow picking up the label config from master rather than v14.x-staging?

Yes, and it's intended: https://github.com/nodejs/node-pr-labeler/blob/d4cf1b8b9f23189c37917000e5e17e796c770a6b/index.js#L47

richardlau commented Jul 28, 2021

Copy link
Copy Markdown
Member

Is the workflow picking up the label config from master rather than v14.x-staging?

Yes, and it's intended: https://github.com/nodejs/node-pr-labeler/blob/d4cf1b8b9f23189c37917000e5e17e796c770a6b/index.js#L47

Thanks. It'll apply the wrong labels to npm PRs to LTS, but maybe that's infrequent enough that we just live with it and manually adjust?

aduh95 changed the title deps: upgrade npm to 6.14.14 [v14.x] deps: upgrade npm to 6.14.14 Jul 28, 2021
richardlau pushed a commit that referenced this pull request Jul 28, 2021
deps: upgrade npm to 6.14.14
7557130 
PR-URL: #39553
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>

richardlau commented Jul 28, 2021

Copy link
Copy Markdown
Member

Landed in 7557130

richardlau closed this Jul 28, 2021
richardlau pushed a commit that referenced this pull request Jul 28, 2021
deps: upgrade npm to 6.14.14
ccba211 
PR-URL: #39553
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
deps: upgrade npm to 6.14.14
ddc8dde 
PR-URL: #39553
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
deps: upgrade npm to 6.14.14
acf5279 
PR-URL: #39553
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
This was referenced Jul 28, 2021
Merged
Merged
wraithgar deleted the npm-6.14.14 branch June 26, 2025 15:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
BethGriggs BethGriggs approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL