lib: use validateObject - #39595
Closed
VoltrexKeyva wants to merge 2 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Used the `validateObject()` validator to keep consistency instead of a custom validator which was only used to validate objects.
RaisinTen
reviewed
Jul 31, 2021
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This changes behavior as the parameter options cannot be null or an array, which was possible before. Should we also pass { nullable: true, allowArray: true } as a third argument to validateObject()?
Sorry, something went wrong.
Used the `validateObject()` validator to keep consistency instead of a custom validator which was only used to validate objects.
Copy link
Copy Markdown
Contributor
Author
|
It seems like something went wrong here, re-opening with a different PR. |
Sorry, something went wrong.
VoltrexKeyva
added a commit
to VoltrexKeyva/node
that referenced
this pull request
Jul 31, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: nodejs#39595
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: #39605 Refs: #39595 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.