FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

crypto: implement webcrypto.randomUUID by targos · Pull Request #39648 · nodejs/node · GitHub

/ node Public

crypto: implement webcrypto.randomUUID - #39648

Closed
targos wants to merge 3 commits into
nodejs:masterfrom
targos:webcrypto-randomuuid
ConversationCommits (3)ChecksFiles changed
Closed

crypto: implement webcrypto.randomUUID#39648
targos wants to merge 3 commits into
nodejs:masterfrom
targos:webcrypto-randomuuid

Conversation

targos commented Aug 3, 2021

Copy link
Copy Markdown
Member

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Aug 3, 2021

targos commented Aug 3, 2021

Copy link
Copy Markdown
Member Author

/cc @bcoe

aduh95 reviewed Aug 3, 2021
View reviewed changes
Comment thread lib/internal/crypto/webcrypto.js Outdated
tniessen reviewed Aug 3, 2021
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does this PR intentionally add the Web Crypto WPTs? If so, that seems like a major change regardless of randomUUID support and should probably be at least mentioned in the commit message, or separated from the change (e.g., in a separate commit).

benjamingr approved these changes Aug 4, 2021
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1 with Tobias's comment - I'd prefer that to be a separate commit though not blocking/a huge deal to me. (I agree it's bigger than re-exposing randomUUID on webcrypto.randomUUID)

targos force-pushed the webcrypto-randomuuid branch from 43aad6b to 0ba70d5 Compare August 4, 2021 06:23

targos commented Aug 4, 2021

Copy link
Copy Markdown
Member Author

Split into two commits

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021

nodejs-github-bot commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39450/

targos commented Aug 4, 2021

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1804_sharedlibs_withoutssl_x64/28216/testReport/junit/(root)/test/wpt_test_webcrypto/

Need to skip without SSL

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2021

nodejs-github-bot commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39452/

nodejs-github-bot commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39454/

tniessen approved these changes Aug 4, 2021
View reviewed changes

tniessen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for splitting the changes into separate commits.

nodejs-github-bot commented Aug 4, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39458/

targos added the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 5, 2021
targos added a commit that referenced this pull request Aug 5, 2021
crypto: implement webcrypto.randomUUID
9073603 
Refs: https://wicg.github.io/uuid/
Refs: https://www.chromestatus.com/feature/5689159362543616

PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos added a commit that referenced this pull request Aug 5, 2021
test: pull Web Platform Tests for WebCryptoAPI
0220497 
PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

targos commented Aug 5, 2021

Copy link
Copy Markdown
Member Author

Landed in 58316e2...0220497

targos closed this Aug 5, 2021
targos deleted the webcrypto-randomuuid branch August 5, 2021 14:53

bcoe commented Aug 5, 2021

Copy link
Copy Markdown
Contributor

@targos awesome 🥳

danielleadams pushed a commit that referenced this pull request Aug 16, 2021
crypto: implement webcrypto.randomUUID
93a904d 
Refs: https://wicg.github.io/uuid/
Refs: https://www.chromestatus.com/feature/5689159362543616

PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
test: pull Web Platform Tests for WebCryptoAPI
952a528 
PR-URL: #39648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
danielleadams mentioned this pull request Aug 16, 2021
Merged
coderabbitai Bot mentioned this pull request Apr 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
jasnell jasnell approved these changes
benjamingr benjamingr approved these changes
tniessen tniessen approved these changes

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. webcrypto

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL