lib: cleanup instance validation - #39656
Closed
VoltrexKeyva wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tniessen
approved these changes
Aug 4, 2021
jasnell
reviewed
Aug 5, 2021
Comment thread
lib/internal/url.js
Outdated
Cleaned up the `URLSearchParams`'s `this` validation to increase readability by moving them to an extra helper function.
RaisinTen
approved these changes
Aug 7, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Aug 12, 2021
Cleaned up the `URLSearchParams`'s `this` validation to increase readability by moving them to an extra helper function. PR-URL: #39656 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
Cleaned up the `URLSearchParams`'s `this` validation to increase readability by moving them to an extra helper function. PR-URL: #39656 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up the URLSearchParams's this validation to increase
readability by moving them to an extra helper function.