doc: fix typo in hmac.paramNames default - #39766
Closed
J-Human wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
HarshithaKP
approved these changes
Aug 14, 2021
aduh95
approved these changes
Aug 14, 2021
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Sorry, something went wrong.
tniessen
approved these changes
Aug 14, 2021
Trott
approved these changes
Aug 14, 2021
cjihrig
approved these changes
Aug 14, 2021
panva
approved these changes
Aug 15, 2021
tniessen
approved these changes
Aug 15, 2021
jasnell
approved these changes
Aug 15, 2021
lpinca
approved these changes
Aug 15, 2021
PR-URL: #39766 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Aug 16, 2021
PR-URL: #39766 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a partially quoted string in a inline code block @ docs, specifically at the WebCrypto documentation for HmacParams.