src: remove extra semicolons outside fns - #39800
Closed
codebytere wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
lpinca
approved these changes
Aug 18, 2021
Copy link
Copy Markdown
Contributor
|
Is this a rule we should add to node core? |
Sorry, something went wrong.
jasnell
approved these changes
Aug 18, 2021
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Muscle-memory is a heck of thing. It would be good to see if we can get the c linter to catch these.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
Sorry, something went wrong.
BethGriggs
approved these changes
Aug 18, 2021
addaleax
approved these changes
Aug 18, 2021
tniessen
approved these changes
Aug 19, 2021
cjihrig
approved these changes
Aug 19, 2021
BridgeAR
approved these changes
Aug 19, 2021
gengjiawen
approved these changes
Aug 19, 2021
sxa
approved these changes
Aug 19, 2021
This comment has been minimized.
RaisinTen
approved these changes
Aug 22, 2021
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
codebytere
added a commit
that referenced
this pull request
Aug 25, 2021
PR-URL: #39800 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2021
PR-URL: #39800 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following:
../../third_party/electron_node/src/node_blob.cc:500:65: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi] NODE_MODULE_CONTEXT_AWARE_INTERNAL(blob, node::Blob::Initialize); ^ ../../third_party/electron_node/src/node_blob.cc:501:77: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi] NODE_MODULE_EXTERNAL_REFERENCE(blob, node::Blob::RegisterExternalReferences); ^ 2 errors generated.