[v16.x backport] src: return Maybe<bool> from InitializeContextRuntime() - #39834
Closed
RaisinTen wants to merge 1 commit into
Closed
[v16.x backport] src: return Maybe<bool> from InitializeContextRuntime()#39834RaisinTen wants to merge 1 commit into
RaisinTen wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: nodejs#39695 Backport-PR-URL: nodejs#39834 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
approved these changes
Aug 22, 2021
Copy link
Copy Markdown
Member
|
Nits about the commit message (I'll fix while landing):
Basically, when you backport a PR, you only need to git cherry-pick the commits and fix the conflicts, keeping the original message. |
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darshan Sen darshan.sen@postman.com
PR-URL: #39695
Backport-PR-URL: #39834
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: James M Snell jasnell@gmail.com