meta: update AUTHORS - #39855
Closed
github-actions[bot] wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Trott
approved these changes
Aug 24, 2021
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I checked that these aren't duplicates. I think this can land.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
yay! 🎉 |
Sorry, something went wrong.
Lxxyx
approved these changes
Aug 24, 2021
Copy link
Copy Markdown
Contributor
Author
Commit Queue failed- Loading data for nodejs/node/pull/39855 ✔ Done loading data for nodejs/node/pull/39855 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#39855) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch undefined:actions/authors-update -> nodejs:master Labels meta, fast-track Commits 1 - meta: update AUTHORS Committers 1 - Create or Update Pull Request Action PR-URL: https://github.com/nodejs/node/pull/39855 Reviewed-By: Rich Trott Reviewed-By: Zijian Liu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39855 Reviewed-By: Rich Trott Reviewed-By: Zijian Liu -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 24 Aug 2021 00:14:59 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/39855#pullrequestreview-736667359 ✔ - Zijian Liu (@Lxxyx): https://github.com/nodejs/node/pull/39855#pullrequestreview-736870593 ℹ This PR is being fast-tracked ⚠ GitHub cannot link the author of 'meta: update AUTHORS' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1161618723 |
Sorry, something went wrong.
Mesteery
added a commit
to Mesteery/node
that referenced
this pull request
Aug 24, 2021
Copy link
Copy Markdown
Member
|
Closing this and we can retry it once #39858 lands. |
Sorry, something went wrong.
nodejs-github-bot
pushed a commit
that referenced
this pull request
Aug 24, 2021
Refs: #39855 (comment) PR-URL: #39858 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 24, 2021
Refs: #39855 (comment) PR-URL: #39858 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
Refs: #39855 (comment) PR-URL: #39858 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this PR exists, there's presumably new additions to the AUTHORS file. This is an automatically generated PR by the authors.yml GitHub Action, which runs tools/update-authors.js and submits a new PR or updates an existing PR.
Please note that there might be duplicate entries. If there are, please remove them and add the duplicate emails to .mailmap directly to this PR.