FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

events: fix duplicate require which cause performance penalty by wwwzbwcom · Pull Request #39892 · nodejs/node · GitHub

/ node Public

events: fix duplicate require which cause performance penalty - #39892

Closed
wwwzbwcom wants to merge 1 commit into
nodejs:masterfrom
wwwzbwcom:fix-events-require
ConversationCommits (1)ChecksFiles changed
Closed

events: fix duplicate require which cause performance penalty#39892
wwwzbwcom wants to merge 1 commit into
nodejs:masterfrom
wwwzbwcom:fix-events-require

Conversation

wwwzbwcom commented Aug 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Inspect require multiple times in events

nodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run. labels Aug 26, 2021
VoltrexKeyva reviewed Aug 26, 2021
View reviewed changes
Comment thread lib/events.js Outdated
VoltrexKeyva reviewed Aug 26, 2021
View reviewed changes
Comment thread lib/events.js Outdated
mscdex reviewed Aug 26, 2021
View reviewed changes
Comment thread lib/events.js Outdated

wwwzbwcom commented Aug 26, 2021

Copy link
Copy Markdown
Contributor Author

how can I restart the CI?

VoltrexKeyva commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

how can I restart the CI?

You don't really need to but if you want, you can do that by either closing and re-opening the PR or force pushing your latest commit again with no changes using the git CLI's push subcommand with using both of the options of --amend and --force (-f as an alias).

The force pushing method is recommended.

nodejs-github-bot commented Aug 27, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39687/ 💛

RaisinTen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 27, 2021

jasnell commented Sep 3, 2021

Copy link
Copy Markdown
Member

Something wierd happened in this PR. The commit message is from the release while the actual change is correct. The commit message will need to be fixed before this can land. Removing the author ready label.

jasnell removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 3, 2021

wwwzbwcom commented Sep 3, 2021

Copy link
Copy Markdown
Contributor Author

Something wierd happened in this PR. The commit message is from the release while the actual change is correct. The commit message will need to be fixed before this can land. Removing the author ready label.

fixed

Ayase-252 commented Sep 13, 2021

Copy link
Copy Markdown
Member

@wwwzbwcom, It seems still some weird here. The author of the commit is targos not you.

Do you mind do a rebase and fix the problem of commit author?

wwwzbwcom commented Sep 15, 2021

Copy link
Copy Markdown
Contributor Author

@wwwzbwcom, It seems still some weird here. The author of the commit is targos not you.

Do you mind do a rebase and fix the problem of commit author?

done

Ayase-252 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 15, 2021

nodejs-github-bot commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39949/

nodejs-github-bot commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39951/

Ayase-252 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 15, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2021

github-actions Bot commented Sep 15, 2021

Copy link
Copy Markdown
Contributor

Landed in bea8a90...4a31ea0

github-actions Bot closed this Sep 15, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 15, 2021
events: fix duplicate require which cause performance penalty
4a31ea0 
PR-URL: #39892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
This was referenced Sep 18, 2021
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
events: fix duplicate require which cause performance penalty
a09e187 
PR-URL: #39892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
events: fix duplicate require which cause performance penalty
f666f5a 
PR-URL: #39892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This was referenced Sep 22, 2021
Open
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
JungMinu JungMinu approved these changes
Ayase-252 Ayase-252 approved these changes
BridgeAR BridgeAR approved these changes
Lxxyx Lxxyx approved these changes
RaisinTen RaisinTen approved these changes
+3 more reviewers
mscdex mscdex left review comments
VoltrexKeyva VoltrexKeyva left review comments
Linkgoron Linkgoron approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL