FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: update token used for pull requests by Trott · Pull Request #39907 · nodejs/node · GitHub

/ node Public

build: update token used for pull requests - #39907

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:secrets
ConversationCommits (2)ChecksFiles changed
Closed

build: update token used for pull requests#39907
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:secrets

Conversation

Trott commented Aug 27, 2021

Copy link
Copy Markdown
Member

Trott requested review from bnb and targos August 27, 2021 03:51
nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 27, 2021
Trott mentioned this pull request Aug 27, 2021
Closed

Trott commented Aug 27, 2021

Copy link
Copy Markdown
Member Author

I pushed this PR branch or the actions/authors-update branch on nodejs/node, and then ran the workflow on that branch.

Here's the run: https://github.com/nodejs/node/runs/3439618049

And here's the resulting PR: #39908

In that PR, the GitHub CI ran, so I think this is good to land.

Trott mentioned this pull request Aug 27, 2021
Closed
Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 27, 2021

github-actions Bot commented Aug 27, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Mesteery commented Aug 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Can you also change the name and email of the committer by the name and email of the bot?
And there is also find-inactive-collaborators.yml to update. (i just saw the other pr)

Trott mentioned this pull request Aug 27, 2021
Closed

Trott commented Aug 27, 2021

Copy link
Copy Markdown
Member Author

Can you also change the name and email of the committer by the name and email of the bot?
And there is also find-inactive-collaborators.yml to update. (i just saw the other pr)

What do others think? Node.js github-bot is a separate bot that isn't involved in this, so I'm not sure. github-bot code is at https://github.com/nodejs/github-bot and doesn't use GitHub Actions.

Mesteery commented Aug 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

I just looked at #39908 (in your comment) whose author is @nodejs-github-bot.

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 30, 2021

github-actions Bot commented Aug 30, 2021

Copy link
Copy Markdown
Contributor

Landed in 660b1d1...e8718b2

github-actions Bot closed this Aug 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Aug 30, 2021
build: update token used for pull requests
e8718b2 
Refs: #39874 (comment)

PR-URL: #39907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2021
build: update token used for pull requests
0ff88f3 
Refs: #39874 (comment)

PR-URL: #39907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos mentioned this pull request Sep 6, 2021
Merged
Trott deleted the secrets branch September 25, 2022 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes
bnb Awaiting requested review from bnb
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL