test: pass URL's toascii.window.js WPT - #39910
Closed
XadillaX wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
XadillaX
force-pushed
the
test-toascii-window.js
branch
2 times, most recently
from
aea1c96 to
353f8dc
Compare
August 27, 2021 08:57
benjamingr
approved these changes
Aug 27, 2021
Linkgoron
reviewed
Aug 27, 2021
Comment thread
test/common/wpt.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
? seems unnecessary
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
An alternative is to write: this.scriptsModifier?.(obj);
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
ah, just a typo. i'll edit it.
Sorry, something went wrong.
Linkgoron
approved these changes
Aug 27, 2021
tniessen
approved these changes
Aug 28, 2021
jasnell
approved these changes
Aug 28, 2021
This comment has been minimized.
watilde
approved these changes
Aug 29, 2021
XadillaX
force-pushed
the
test-toascii-window.js
branch
from
353f8dc to
4cd8239
Compare
August 30, 2021 03:26
This comment has been minimized.
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
XadillaX
added a commit
that referenced
this pull request
Aug 30, 2021
PR-URL: #39910 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Copy link
Copy Markdown
Member
|
Should probably be backported with or after #39848 |
Sorry, something went wrong.
targos
pushed a commit
to targos/node
that referenced
this pull request
Oct 9, 2021
PR-URL: nodejs#39910 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.