FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

repl: fix top level await with surrogate characters by Mesteery · Pull Request #39931 · nodejs/node · GitHub

/ node Public

repl: fix top level await with surrogate characters - #39931

Closed
Mesteery wants to merge 2 commits into
nodejs:masterfrom
Mesteery:repl-await-surrogates
ConversationCommits (2)ChecksFiles changed
Closed

repl: fix top level await with surrogate characters#39931
Mesteery wants to merge 2 commits into
nodejs:masterfrom
Mesteery:repl-await-surrogates

Conversation

Mesteery commented Aug 29, 2021

Copy link
Copy Markdown
Contributor

Fixes: #39929

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Aug 29, 2021
Trott reviewed Aug 29, 2021
View reviewed changes
Comment thread lib/internal/repl/await.js Outdated
Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 29, 2021

Mesteery commented Aug 29, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This does not work for entries like await "😀😀😀";"😀".
edit: I think I finally succeeded.
edit: It's more complicated than I thought. 😅

Mesteery closed this Aug 29, 2021
Mesteery reopened this Aug 29, 2021
Mesteery closed this Aug 29, 2021
Mesteery deleted the repl-await-surrogates branch August 29, 2021 17:29
Mesteery restored the repl-await-surrogates branch August 29, 2021 18:01

Trott commented Aug 29, 2021

Copy link
Copy Markdown
Member

This does not work for entries like await "😀😀😀";"😀".
edit: I think I finally succeeded.
edit: It's more complicated than I thought. 😅

While getting it exactly right is, of course, preferred, it's totally OK to land something that is an improvement that still leaves some edge cases unsolved. await "😀😀😀";"😀" doesn't work currently, so it's OK if your fix doesn't fix that.

Mesteery reopened this Aug 29, 2021
Mesteery force-pushed the repl-await-surrogates branch from b14b25e to 458a9fd Compare August 29, 2021 22:38

Mesteery commented Aug 29, 2021

Copy link
Copy Markdown
Contributor Author

Ok, thanks! Finally I succeeded, and I don't know why I was looking for a complex solution. Just break the surrogates, so the array has the same length as the string and the surrogates will normally not be broken at the end (unless there is a bug with some indexes or acorn, but I doubt it)

BridgeAR approved these changes Aug 30, 2021
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

VoltrexKeyva added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Aug 30, 2021
Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 30, 2021
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 2, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2021

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Sep 6, 2021 •
edited by jasnell
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39820/ 💚

targos self-assigned this Sep 8, 2021
targos pushed a commit to targos/node that referenced this pull request Sep 8, 2021
repl: fix top level await with surrogate characters
addb30f 
Fixes: nodejs#39929

PR-URL: nodejs#39931
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>

targos commented Sep 8, 2021

Copy link
Copy Markdown
Member

Landed in addb30f

targos closed this Sep 8, 2021
targos removed their assignment Sep 8, 2021
Mesteery deleted the repl-await-surrogates branch September 8, 2021 19:16
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
repl: fix top level await with surrogate characters
d6124d8 
Fixes: #39929

PR-URL: #39931
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott left review comments
jasnell jasnell approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
Leko Leko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

await an expression with surrogate characters raises a SyntaxError

9 participants

Back | FazBrowse Home | New Git URL