FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add triagers to the table of contents. by iam-frankqiu · Pull Request #39969 · nodejs/node · GitHub

/ node Public

doc: add triagers to the table of contents. - #39969

Merged
Trott merged 1 commit into
nodejs:masterfrom
iam-frankqiu:add_triagers
Oct 3, 2021
ConversationCommits (1)ChecksFiles changed
Merged

doc: add triagers to the table of contents.#39969
Trott merged 1 commit into
nodejs:masterfrom
iam-frankqiu:add_triagers

Conversation

iam-frankqiu commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

I think we should add Triagers to the table of contents for Collaborators and Release keys have already in.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 1, 2021

targos commented Sep 1, 2021

Copy link
Copy Markdown
Member

I'd also support just removing the table of contents as GitHub now generates one automatically:

iam-frankqiu commented Sep 1, 2021

Copy link
Copy Markdown
Contributor Author

I'd also support just removing the table of contents as GitHub now generates one automatically:

Is the GitHub client?

targos commented Sep 1, 2021

Copy link
Copy Markdown
Member

Is the GitHub client?

The website: https://github.com/nodejs/node#readme

iam-frankqiu commented Sep 1, 2021

Copy link
Copy Markdown
Contributor Author

Is the GitHub client?

The website: https://github.com/nodejs/node#readme

In case someone doesn't notice this button like me, we should still keep it.

lpinca commented Sep 1, 2021

Copy link
Copy Markdown
Member

There is a typo in commit title: conents -> contents.

iam-frankqiu commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

There is a typo in commit title: conents -> contents.

Sorry. I will be more careful next time. Hope it won't affect landing.

iam-frankqiu added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 3, 2021

jasnell commented Sep 3, 2021

Copy link
Copy Markdown
Member

Landed in 17098b2ef69c

jasnell closed this Sep 3, 2021

iam-frankqiu commented Oct 3, 2021

Copy link
Copy Markdown
Contributor Author

Landed in 17098b2ef69c

I don't know why. But it seems like not landed successfully.

iam-frankqiu reopened this Oct 3, 2021
doc: add triagers to the table of contents
1811396 
PR-URL: nodejs#39969
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Trott commented Oct 3, 2021

Copy link
Copy Markdown
Member

Landed in 1811396

Trott merged commit 1811396 into nodejs:master Oct 3, 2021
targos pushed a commit that referenced this pull request Oct 4, 2021
doc: add triagers to the table of contents
f71ac57 
PR-URL: #39969
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams mentioned this pull request Oct 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes
richardlau richardlau approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL