FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add more to subsystems by iam-frankqiu · Pull Request #39971 · nodejs/node · GitHub

/ node Public

doc: add more to subsystems - #39971

Closed
iam-frankqiu wants to merge 2 commits into
nodejs:masterfrom
iam-frankqiu:doc_add_subsystems
ConversationCommits (2)ChecksFiles changed
Closed

doc: add more to subsystems#39971
iam-frankqiu wants to merge 2 commits into
nodejs:masterfrom
iam-frankqiu:doc_add_subsystems

Conversation

iam-frankqiu commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

Add benchmark deps typings to subsystems.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 1, 2021

aduh95 commented Sep 1, 2021

Copy link
Copy Markdown
Contributor

The full list of subsystems can be found at https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js. Maybe we should list them all here, or replace the list with a link to the JS file.

iam-frankqiu commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

The full list of subsystems can be found at https://github.com/nodejs/core-validate-commit/blob/main/lib/rules/subsystem.js. Maybe we should list them all here, or replace the list with a link to the JS file.

Good idea. How about this time?

tniessen reviewed Sep 2, 2021
View reviewed changes
Comment thread doc/guides/contributing/pull-requests.md Outdated

iam-frankqiu commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

I don't know what's wrong with my code? I only add several lines of code in the markdown file. But the action of build-windows(windows-2022) still failed. Is it a bug? @nodejs/actions

aduh95 commented Sep 2, 2021

Copy link
Copy Markdown
Contributor

It is unrelated to your PR, see #39976.

aduh95 reviewed Sep 2, 2021
View reviewed changes
Comment thread doc/guides/contributing/pull-requests.md Outdated
Comment thread doc/guides/contributing/pull-requests.md Outdated
iam-frankqiu requested a review from aduh95 September 3, 2021 04:13

aduh95 commented Sep 3, 2021

Copy link
Copy Markdown
Contributor

Can you fix the linter error please?

iam-frankqiu commented Sep 3, 2021

Copy link
Copy Markdown
Contributor Author

Can you fix the linter error please?

Sure.

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 3, 2021
lpinca approved these changes Sep 4, 2021
View reviewed changes
Comment thread doc/guides/contributing/pull-requests.md Outdated
Ayase-252 pushed a commit that referenced this pull request Sep 15, 2021
doc: add full list of subsystems
166e52b 
PR-URL: #39971
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>

Ayase-252 commented Sep 15, 2021

Copy link
Copy Markdown
Member

Landed in 166e52b

Ayase-252 closed this Sep 15, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
doc: add full list of subsystems
bebbd22 
PR-URL: #39971
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
doc: add full list of subsystems
8aad81d 
PR-URL: #39971
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
Ayase-252 Ayase-252 approved these changes
aduh95 aduh95 approved these changes
tniessen Awaiting requested review from tniessen

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL