FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix C4805 MSVC warning by targos · Pull Request #39998 · nodejs/node · GitHub

/ node Public

src: fix C4805 MSVC warning - #39998

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-bool-warning
Closed

src: fix C4805 MSVC warning#39998
targos wants to merge 1 commit into
nodejs:masterfrom
targos:fix-bool-warning

Conversation

targos commented Sep 5, 2021

Copy link
Copy Markdown
Member

'==' : unsafe mix of type 'bool' and type 'int' in operation

'==' : unsafe mix of type 'bool' and type 'int' in operation
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Sep 5, 2021
targos added windows Issues and PRs related to the Windows platform. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 5, 2021
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2021

Copy link
Copy Markdown
Collaborator

jasnell added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 5, 2021

github-actions Bot commented Sep 5, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos added a commit that referenced this pull request Sep 7, 2021
'==' : unsafe mix of type 'bool' and type 'int' in operation

PR-URL: #39998
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

targos commented Sep 7, 2021

Copy link
Copy Markdown
Member Author

Landed in dadea4a

targos closed this Sep 7, 2021
targos deleted the fix-bool-warning branch September 7, 2021 10:23
targos removed fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Sep 7, 2021
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
'==' : unsafe mix of type 'bool' and type 'int' in operation

PR-URL: #39998
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs mentioned this pull request Sep 21, 2021
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL