test: fix test-dgram-udp6-link-local-address on Windows - #40005
Closed
targos wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Error was: node .\test\parallel\test-dgram-udp6-link-local-address.js
node:events:371
throw er; // Unhandled 'error' event
^
Error: getaddrinfo ENOTFOUND fe80::a030:196b:d025:69fb%vEthernet (Ethernet 2)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:26)
Emitted 'error' event on Socket instance at:
at GetAddrInfoReqWrap.callback (node:dgram:326:12)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:17) {
errno: -3008,
code: 'ENOTFOUND',
syscall: 'getaddrinfo',
hostname: 'fe80::a030:196b:d025:69fb%vEthernet (Ethernet 2)'
}
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Bunch of relevant failures in CI |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
At least it passed on Windows 😄 |
Sorry, something went wrong.
targos
force-pushed
the
fix-test-udp-win
branch
from
45526dc to
d976297
Compare
September 5, 2021 15:38
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It's fixed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Trott
approved these changes
Sep 20, 2021
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 20, 2021
PR-URL: #40005 Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40005 Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
PR-URL: #40005 Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the test on my machine at least.