dns: cleanup validation - #40061
Closed
VoltrexKeyva wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
VoltrexKeyva
force-pushed
the
patch-8
branch
from
4b8896c to
3a13bf1
Compare
September 10, 2021 04:35
tniessen
reviewed
Sep 10, 2021
Comment thread
lib/internal/dns/utils.js
Outdated
aduh95
approved these changes
Sep 10, 2021
Comment thread
lib/internal/dns/utils.js
Outdated
The `validateString()` validator should cleanup the validation and keep consistency.
VoltrexKeyva
force-pushed
the
patch-8
branch
from
3a13bf1 to
e65a126
Compare
September 10, 2021 17:44
lpinca
approved these changes
Sep 11, 2021
This comment has been minimized.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
Sep 13, 2021
This was referenced Sep 14, 2021
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
The `validateString()` validator should cleanup the validation and keep consistency. PR-URL: #40061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 17, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
The `validateString()` validator should cleanup the validation and keep consistency. PR-URL: #40061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
The `validateString()` validator should cleanup the validation and keep consistency. PR-URL: #40061 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The validateString() validator should cleanup the validation and keep consistency.