FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark test-crypto-timing-safe-equal-benchmarks flaky by richardlau · Pull Request #40065 · nodejs/node · GitHub

/ node Public

test: mark test-crypto-timing-safe-equal-benchmarks flaky - #40065

Closed
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:cryptotiming
ConversationCommits (1)ChecksFiles changed
Closed

test: mark test-crypto-timing-safe-equal-benchmarks flaky#40065
richardlau wants to merge 1 commit into
nodejs:masterfrom
richardlau:cryptotiming

Conversation

richardlau commented Sep 10, 2021

Copy link
Copy Markdown
Member

This has been flaky for a long time.

Refs: #38226

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2021
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 10, 2021
richardlau mentioned this pull request Sep 10, 2021
Closed
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 10, 2021

nodejs-github-bot commented Sep 10, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39898/

richardlau commented Sep 10, 2021

Copy link
Copy Markdown
Member Author

Appears to have worked (test marked as flaky): https://ci.nodejs.org/job/node-test-commit-linuxone/28795/nodes=rhel7-s390x/testReport/(root)/test/pummel_test_crypto_timing_safe_equal_benchmarks_/

richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 10, 2021
mhdawson approved these changes Sep 10, 2021
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 12, 2021

github-actions Bot commented Sep 12, 2021 •
edited by aduh95
Loading

Copy link
Copy Markdown
Contributor

Landed in b6ac7e6

github-actions Bot closed this Sep 12, 2021
aduh95 pushed a commit that referenced this pull request Sep 12, 2021
test: mark test-crypto-timing-safe-equal-benchmarks flaky
b6ac7e6 
PR-URL: #40065
Refs: #38226
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau deleted the cryptotiming branch September 12, 2021 19:34
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
test: mark test-crypto-timing-safe-equal-benchmarks flaky
04efafd 
PR-URL: #40065
Refs: #38226
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
test: mark test-crypto-timing-safe-equal-benchmarks flaky
4367a61 
PR-URL: #40065
Refs: #38226
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
tniessen tniessen approved these changes
+2 more reviewers
mhdawson mhdawson approved these changes
AshCripps AshCripps approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL