FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix internet/test-dns by Trott · Pull Request #40083 · nodejs/node · GitHub

/ node Public

test: fix internet/test-dns - #40083

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-test-dns
ConversationCommits (1)ChecksFiles changed
Closed

test: fix internet/test-dns#40083
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-test-dns

Conversation

Trott commented Sep 11, 2021

Copy link
Copy Markdown
Member

internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

test: fix internet/test-dns
a85df2d 
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 11, 2021
Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. and removed test Issues and PRs related to the tests. needs-ci PRs that need a full CI run. labels Sep 11, 2021

github-actions Bot commented Sep 11, 2021

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott commented Sep 11, 2021

Copy link
Copy Markdown
Member Author

Only the nightly CI runs the internet tests, so this doesn't show up in our CI runs for PRs. Here it is failing in the nightly run, though: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/22314/testReport/junit/(root)/test/internet_test_dns/

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 11, 2021

Trott commented Sep 11, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

Internet CI against this PR: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/22318/ ✅

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39908/

Trott commented Sep 11, 2021

Copy link
Copy Markdown
Member Author

@nodjes/testing (Also, if you review, please consider thumbs-upping the fast-track request above!)

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39910/

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39911/

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39912/

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39913/

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39914/

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39915/

nodejs-github-bot commented Sep 11, 2021

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39917/

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 11, 2021

github-actions Bot commented Sep 11, 2021

Copy link
Copy Markdown
Contributor

Landed in e267467...ec555b0

github-actions Bot closed this Sep 11, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 11, 2021
test: fix internet/test-dns
ec555b0 
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

PR-URL: #40083
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This was referenced Sep 14, 2021
Open
Open
This was referenced Sep 16, 2021
Open
Open
Open
Open
Open
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
test: fix internet/test-dns
6037dd0 
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

PR-URL: #40083
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
test: fix internet/test-dns
5b5e272 
internet/test-dns is failing due to a typo that inadvertently sends a
boolean instead of a regular expression.

PR-URL: #40083
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
Trott deleted the fix-test-dns branch September 25, 2022 17:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tniessen tniessen approved these changes
richardlau richardlau approved these changes
Ayase-252 Ayase-252 approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL