FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: prepare README.md for stricter linting by Trott · Pull Request #40137 · nodejs/node · GitHub

/ node Public

doc: prepare README.md for stricter linting - #40137

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:readme
Closed

doc: prepare README.md for stricter linting#40137
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:readme

Conversation

Trott commented Sep 17, 2021

Copy link
Copy Markdown
Member

No description provided.

Trott requested a review from aduh95 September 17, 2021 22:45
nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Sep 17, 2021

Trott commented Sep 17, 2021

Copy link
Copy Markdown
Member Author

Adding the blocked label because this can't land until the changes here are accommodated in node-core-utils.

Trott commented Sep 17, 2021

Copy link
Copy Markdown
Member Author

Adding the blocked label because this can't land until the changes here are accommodated in node-core-utils.

Trott added the blocked PRs that are blocked by other issues or PRs. label Sep 17, 2021
Trott added a commit to Trott/node-core-utils that referenced this pull request Sep 17, 2021
This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

Trott commented Sep 17, 2021

Copy link
Copy Markdown
Member Author

This will be unblocked when nodejs/node-core-utils#561 lands and is published to npm.

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. One upside of this change is it will force collaborators to use the last version of ncu, I know I'm sometimes lagging behind.

Trott commented Sep 17, 2021

Copy link
Copy Markdown
Member Author

LGTM. One upside of this change is it will force collaborators to use the last version of ncu, I know I'm sometimes lagging behind.

Yeah, we'll have to get the word out.

Trott added a commit to Trott/node-core-utils that referenced this pull request Sep 19, 2021
This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137
Trott added a commit to nodejs/node-core-utils that referenced this pull request Sep 20, 2021
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. labels Sep 20, 2021
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2021

Copy link
Copy Markdown
Contributor

Landed in 453bb6b...420cdc7

github-actions Bot closed this Sep 20, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 20, 2021
PR-URL: #40137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
PR-URL: #40137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs mentioned this pull request Sep 21, 2021
1 task
Trott deleted the readme branch September 25, 2022 17:13
johnfrench3 pushed a commit to johnfrench3/core-utils-node that referenced this pull request Nov 2, 2022
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
renawolford6 added a commit to renawolford6/node-dev-build-core-utils that referenced this pull request Nov 10, 2022
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
Developerarif2 pushed a commit to Developerarif2/node-core-utils that referenced this pull request Jan 27, 2023
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
gerkai added a commit to gerkai/node-core-utils-project-build that referenced this pull request Jan 27, 2023
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
patrickm68 added a commit to patrickm68/NodeJS-core-utils that referenced this pull request Sep 14, 2023
* feat: prepare ncu for new README format

This accommodates both the current README format and the upcoming README
format.

Refs: nodejs/node#40137

* fixup! feat: prepare ncu for new README format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL